pretecno/crowdsec-bouncer-traefik-plugin
3
0
Fork 0
mirror of https://github.com/maxlerebourg/crowdsec-bouncer-traefik-plugin.git synced 2026-09-04 21:18:52 +02:00
Code Issues Packages Releases Activity

🍱 reduce slop

Browse Source
This commit is contained in:
maxlerebourg
2026-09-03 10:17:52 +02:00
committed by GitHub
parent c7096d7c09
commit 5d0ae282b8
1 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bouncer_test.go
+2 -11
View File
@@ -557,12 +557,8 @@ func Test_appsecQuery_unreadableBodyGetNotDropped(t *testing.T) {
} }
} }
// Test_appsecQuery_reusesConnection is a regression test for issue #384: the // Test_appsecQuery_reusesConnection is a regression test for issue #384: the appsec response
// appsec response body must be drained so net/http can return the connection to // body must be drained for non-200 status response so net/http can return the conn to the idle pool.
// the idle pool. Without it every request opened a fresh TCP connection and left
// it in TIME_WAIT. The 403 and 500 cases matter as much as 200: they return
// before the end of the function, and they are what a site under attack or a
// wedged appsec produce in volume.
func Test_appsecQuery_reusesConnection(t *testing.T) { func Test_appsecQuery_reusesConnection(t *testing.T) {
for _, status := range []int{http.StatusOK, http.StatusForbidden, http.StatusInternalServerError} { for _, status := range []int{http.StatusOK, http.StatusForbidden, http.StatusInternalServerError} {
t.Run(http.StatusText(status), func(t *testing.T) { t.Run(http.StatusText(status), func(t *testing.T) {
@@ -573,8 +569,6 @@ func Test_appsecQuery_reusesConnection(t *testing.T) {
conns[r.RemoteAddr] = true conns[r.RemoteAddr] = true
mu.Unlock() mu.Unlock()
rw.WriteHeader(status) rw.WriteHeader(status)
// a non-empty body is what makes the connection unusable when it
// is not drained; an empty one is already at EOF
if _, errWrite := rw.Write([]byte(`{"action":"allow"}`)); errWrite != nil { if _, errWrite := rw.Write([]byte(`{"action":"allow"}`)); errWrite != nil {
t.Errorf("appsec stub write: %v", errWrite) t.Errorf("appsec stub write: %v", errWrite)
} }
@@ -593,9 +587,6 @@ func Test_appsecQuery_reusesConnection(t *testing.T) {
} }
const calls = 10 const calls = 10
// Not a range-over-int loop: yaegi v0.16.1, which is what Traefik
// bundles and what `make yaegi_test` pins, cannot parse that form
// and panics with "nil type".
for i := 0; i < calls; i++ { //nolint:intrange for i := 0; i < calls; i++ { //nolint:intrange
req, _ := http.NewRequest(http.MethodGet, "http://localhost/", nil) req, _ := http.NewRequest(http.MethodGet, "http://localhost/", nil)
_ = appsecQuery(bouncer, "1.2.3.4", req) _ = appsecQuery(bouncer, "1.2.3.4", req)